RFR: 8267505: {List, Set, Map}PropertyBase::bind should check against identity

Kevin Rushforth kcr at openjdk.java.net
Mon May 24 12:50:17 UTC 2021


On Mon, 24 May 2021 11:56:35 GMT, Jose Pereda <jpereda at openjdk.org> wrote:

> ListPropertyBase::bind, SetPropertyBase::bind, MapPropertyBase::bind have a check on whether a different instance of the observable is the same, and this PR changes that to check against identity.
> 
> Tests are included.

This seems like the right fix to me, but it begs the question of why `.equals()` was used in the first place when these classes were created. It's possible that it was just a mistake. Can you think of any cases where two sets that are not the same object, but are `equals` should be treated as the same for the purpose of checking whether to unbind? I can't, but want to take a closer look.

-------------

PR: https://git.openjdk.java.net/jfx/pull/516


More information about the openjfx-dev mailing list