RFR: 8196065: ListChangeListener getRemoved() returns items that were not removed. [v7]

Michael Strauß mstrauss at openjdk.java.net
Fri May 28 23:35:42 UTC 2021


> The documentation for `ObservableListBase.nextRemove` states that a single change always refers to the current state of the list, which likely means that multiple disjoint removed ranges need to be applied in order, otherwise the next change's `getFrom` doesn't refer to the correct index.
> 
> `SelectedItemsReadOnlyObservableList` doesn't apply removals to `itemsRefList`, which means that subsequent removals will refer to the wrong index when retrieving the removed elements. This PR fixes the calculation of the current index.

Michael Strauß has updated the pull request incrementally with one additional commit since the last revision:

  Ignored tests that fail for a different reason

-------------

Changes:
  - all: https://git.openjdk.java.net/jfx/pull/478/files
  - new: https://git.openjdk.java.net/jfx/pull/478/files/fbe8aa66..950c894a

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jfx&pr=478&range=06
 - incr: https://webrevs.openjdk.java.net/?repo=jfx&pr=478&range=05-06

  Stats: 25 lines in 1 file changed: 3 ins; 16 del; 6 mod
  Patch: https://git.openjdk.java.net/jfx/pull/478.diff
  Fetch: git fetch https://git.openjdk.java.net/jfx pull/478/head:pull/478

PR: https://git.openjdk.java.net/jfx/pull/478


More information about the openjfx-dev mailing list