RFR: 8274022 fixing critical memory leak in the ControlAcceleratorSupport [v3]

[Michael Strauß]

On Tue, 2 Nov 2021 08:16:41 GMT, Florian Kirmaier <fkirmaier at openjdk.org> wrote:

>> This fixes the new ControlAcceleratorBug which was Introduced in JavaFX17.
>> To fix it, I've made the Value of the WeakHashMap also weak. 
>> We only keep this value to remove it as a listener later on. Therefore there shouldn't be issues by making this value weak.
>> 
>> 
>> I've seen this Bug very very often, in the last weeks. Most of the applications I've seen are somehow affected by this bug.
>> 
>> It basically **breaks every application with menu bars and multiple stages** - which is the majority of enterprise applications. It's especially annoying because it takes some time until the application gets unstable.
>> 
>> Therefore **I would recommend** after this fix is approved, **to make a new version for JavaFX17** with this fix because this bug is so severe.
>
> Florian Kirmaier has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8274022
>   Simplified code related to WeakHashMaps

Marked as reviewed by mstrauss (Author).

-------------

PR: https://git.openjdk.java.net/jfx/pull/659