RFR: 8273485: Deadlock when also using Swing and exiting Fullscreen on Mac [v7]

[Florian Kirmaier]

On Sat, 30 Oct 2021 13:35:39 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Florian Kirmaier has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   JDK-8273485
>>   Fixing toggle fullscreen!
>
> modules/javafx.graphics/src/main/native-glass/mac/GlassViewDelegate.m line 1345:
> 
>> 1343:         if (self->nativeFullScreenModeWindow)
>> 1344:         {
>> 1345:             [[self->nsView window] toggleFullScreen:self];
> 
> I see you added the call to `toggleFullScreen` back in, but you now pass `self` to the method, where the previous code passed `nil`. Unless there is a compelling reason why you need to change it, I recommend to restore _exactly_ the former code, such that there are no diffs:
> 
> 
>             [self->nativeFullScreenModeWindow performSelector:@selector(toggleFullScreen:) withObject:nil];

With the previous version, I get a "beep" sound when closing a window.
But with the changed line, it works for me and I don't get any issues.
The beep sound also was the original reason, why I've removed the line.

-------------

PR: https://git.openjdk.java.net/jfx/pull/622