RFR: 8274854: Mnemonics for menu containing numeric text not working [v4]

Kevin Rushforth kcr at openjdk.java.net
Tue Nov 2 13:56:17 UTC 2021


On Sat, 30 Oct 2021 20:40:12 GMT, Michael Strauß <mstrauss at openjdk.org> wrote:

>> This PR fixes an issue with mnemonic parsing by removing the restriction that a mnemonic symbol must be a letter. Now, it can be any character except whitespace.
>
> Michael Strauß has updated the pull request incrementally with four additional commits since the last revision:
> 
>  - revert rename
>  - revert rename
>  - test for KeyCombination
>  - renamed TextBinding to MnemonicParser, refactored tests

The latest version looks good.

-------------

Marked as reviewed by kcr (Lead).

PR: https://git.openjdk.java.net/jfx/pull/647


More information about the openjfx-dev mailing list