RFR: 8267059: Gradle :clean and :apps tasks fail on Windows if ANT_HOME contains spaces [v2]
drmarmac
duke at openjdk.java.net
Wed Nov 3 13:54:15 UTC 2021
On Fri, 4 Jun 2021 05:04:17 GMT, Michael Strauß <mstrauss at openjdk.org> wrote:
>> This PR fixes an issue when building OpenJFX on Windows and command-line arguments contain paths with spaces.
>>
>> The problem is that on Windows, `ant` is invoked via `cmd`, which leads to quotes being interpreted twice. This can be fixed with the option `cmd /s`, which prevents interpreting quotes on the rest of the command line. The result is as if the rest of the command line had been typed verbatim at the command prompt.
>
> Michael Strauß has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
>
> - Merge branch 'master' into fixes/JDK-8267059
> - Use cmd /s option when building on Windows
Tested this on Windows, seems to fix the issue.
-------------
Marked as reviewed by drmarmac at github.com (no known OpenJDK username).
PR: https://git.openjdk.java.net/jfx/pull/499
More information about the openjfx-dev
mailing list