RFR: 8274274: Update JUnit to version 5.8.1 [v2]
Kevin Rushforth
kcr at openjdk.java.net
Thu Nov 11 15:21:42 UTC 2021
On Thu, 11 Nov 2021 08:44:54 GMT, John Hendrikx <jhendrikx at openjdk.org> wrote:
>> The vintage engine pulls this in, so I think we may be forced to upgrade from 4.8.2 JUnit 4 to 4.13.2 JUnit 4 as well, although the current setup seems to work (I remember some Rules being deprecated in later JUnit 4, specifically rules for catching exceptions which could require rewriting those tests to use `assertThrows`).
>
> Assuming this is okay now as approvals have been received.
Yes, this is fine.
>> Will try block
>
> I couldn't block opentest4j. Apparently this is a project that harmonizes the exceptions thrown by various test frameworks (not just JUnit 5) and JUnit 5 depends on it for the exceptions it uses to signal test failures and other error conditions. It is a fairly small project (6 classes only) licensed under the Apache 2.0 license: https://github.com/ota4j-team/opentest4j
Since we only use JUnit for build / test, and don't directly depend on `opentest4j`, this is not a problem.
-------------
PR: https://git.openjdk.java.net/jfx/pull/633
More information about the openjfx-dev
mailing list