RFR: 8274022 fixing critical memory leak in the ControlAcceleratorSupport [v4]

Florian Kirmaier fkirmaier at openjdk.java.net
Mon Nov 15 08:15:11 UTC 2021


> This fixes the new ControlAcceleratorBug which was Introduced in JavaFX17.
> To fix it, I've made the Value of the WeakHashMap also weak. 
> We only keep this value to remove it as a listener later on. Therefore there shouldn't be issues by making this value weak.
> 
> 
> I've seen this Bug very very often, in the last weeks. Most of the applications I've seen are somehow affected by this bug.
> 
> It basically **breaks every application with menu bars and multiple stages** - which is the majority of enterprise applications. It's especially annoying because it takes some time until the application gets unstable.
> 
> Therefore **I would recommend** after this fix is approved, **to make a new version for JavaFX17** with this fix because this bug is so severe.

Florian Kirmaier has updated the pull request incrementally with one additional commit since the last revision:

  8274022
  removed an unused import

-------------

Changes:
  - all: https://git.openjdk.java.net/jfx/pull/659/files
  - new: https://git.openjdk.java.net/jfx/pull/659/files/bbc39f24..d2a1c448

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jfx&pr=659&range=03
 - incr: https://webrevs.openjdk.java.net/?repo=jfx&pr=659&range=02-03

  Stats: 1 line in 1 file changed: 0 ins; 1 del; 0 mod
  Patch: https://git.openjdk.java.net/jfx/pull/659.diff
  Fetch: git fetch https://git.openjdk.java.net/jfx pull/659/head:pull/659

PR: https://git.openjdk.java.net/jfx/pull/659


More information about the openjfx-dev mailing list