RFR: 8274061: Tree-/TableRowSkin: misbehavior on switching skin [v2]
Jeanette Winzenburg
fastegal at openjdk.java.net
Mon Nov 15 13:31:41 UTC 2021
On Mon, 1 Nov 2021 12:59:42 GMT, Marius Hanl <mhanl at openjdk.org> wrote:
>> well .. that would be a merge conflict, had you updated the code comment in your PR As noted in my comments to Ajit's review, the listener registration is simply moved (including the code comment .. belatedly :)
>>
>> Not sure how to handle it from here - following the rules, we might need a follow-up issue to the issue fixed in your PR?
>
> My PR is already merged, so this is not a problem. :)
> I dont know, but since this is only fixing a (also before) wrong comment it might be okay as it is very minor? :)
FYI: now the listener registration - including the incorrect code comment (which is the same as in current master) - is back at the old location in the re-inserted setupTreeTableViewListeners. So still need input whether it's okay to correct the code comment here.
-------------
PR: https://git.openjdk.java.net/jfx/pull/632
More information about the openjfx-dev
mailing list