RFR: 8277122: SplitPane divider drag can hang the layout
Marius Hanl
mhanl at openjdk.java.net
Sat Nov 20 20:03:05 UTC 2021
On Fri, 19 Nov 2021 12:39:23 GMT, Jeanette Winzenburg <fastegal at openjdk.org> wrote:
> interesting issue - and fix :) Verified the mis-behaviour before the fix and its working after.
>
> Wondering, though (read: I don't understand )
>
> * why the layout details in the splitpane hinders the visual update of a completely unrelated component (like the combo)?
> * why does it only happen on increasing the divider pos, not on decreasing?
>
> As to the test: would prefer to also see a test of the fixed effect (vs. the fix implementation of not re-entering layout) - might be a bit tricky, though.
- the combobox is a children of the splitpane, so therefore it is affected by the invalid layout state of the splitpane.
- it can also happen when decreasing, it might be that you need to set the min width to 0 of the left content of the splitpane.
-> The bug is only happening if you drag the divider while being either as far on the left as possible or as far as possible on the right, so that a drag won't affect the divider since it is already at the min/max position. The layout code whoever will basically adjust the divider a second time since it would now be out of bounds
Do you mean something like checking the combobox display text?
-------------
PR: https://git.openjdk.java.net/jfx/pull/669
More information about the openjfx-dev
mailing list