RFR: 8274274: Update JUnit to version 5.8.1 [v6]

[John Hendrikx]

On Sat, 20 Nov 2021 15:54:06 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> John Hendrikx has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Fix white space error
>>  - Allow apiguardian as dependency
>
> build.gradle line 1948:
> 
>> 1946:     dependencies {
>> 1947:         testImplementation group: "junit", name: "junit", version: "4.13.2"
>> 1948:         testImplementation group: "org.junit.jupiter", name: "junit-jupiter", version: "5.8.1"
> 
> We need an explicit list of dependencies here, rather than relying on the maven pom files to bring them in. This is needed for our internal builds where we only host a snapshot of the jar files and not the pom files. Also, it better documents the dependencies. After adding the following to my local build, it all works now:
> 
> 
> testImplementation group: "org.junit.jupiter", name: "junit-jupiter-api", version: "5.8.1"
> testImplementation group: "org.hamcrest", name: "hamcrest-core", version: "1.3"
> testRuntimeOnly group: "org.junit.jupiter", name: "junit-jupiter-engine", version: "5.8.1"
> testRuntimeOnly group: "org.junit.jupiter", name: "junit-jupiter-params", version: "5.8.1"
> testRuntimeOnly group: "org.junit.platform", name: "junit-platform-commons", version: "1.8.1"
> testRuntimeOnly group: "org.junit.platform", name: "junit-platform-engine", version: "1.8.1"
> testRuntimeOnly group: "org.apiguardian", name: "apiguardian-api", version: "1.1.2"
> testRuntimeOnly group: "org.opentest4j", name: "opentest4j", version: "1.2.0"

I've added the dependencies you listed here.

> build.gradle line 1951:
> 
>> 1949:         testRuntimeOnly group: "org.junit.vintage", name: "junit-vintage-engine", version: "5.8.1"
>> 1950: 
>> 1951:          if (BUILD_CLOSED && DO_JCOV)  {
> 
> Minor: you added an extra space of indentation (which is why this line is showing up in the diff).

Fixed

> build.gradle line 2041:
> 
>> 2039: 
>> 2040:     dependencies {
>> 2041:         testImplementation group: "junit", name: "junit", version: "4.13.2"
> 
> This isn't needed and should be removed (rather than updating it).

Removed this and in the other location.

> modules/javafx.base/src/test/java/test/JUnit5Test.java line 34:
> 
>> 32:     @Test
>> 33:     void junit5ShouldWork() {
>> 34:         System.err.println("JUnit 5 test working!");
> 
> I recommend adding a trivial assert here (e.g., `assertNotNull(this)` or similar).

Added

-------------

PR: https://git.openjdk.java.net/jfx/pull/633