RFR: 8197991: Selecting many items in a TableView is very slow

Abhinay Agarwal duke at openjdk.java.net
Mon Nov 22 16:10:28 UTC 2021


On Thu, 18 Nov 2021 08:53:07 GMT, Marius Hanl <mhanl at openjdk.org> wrote:

>> This work improves the performance of `MultipleSelectionModel`  over large data sets by caching some values and avoiding unnecessary calls to `SelectedIndicesList#size`. It further improves the performance by reducing the number of iterations required to find the index of an element in the BitSet.
>> 
>> The work is based on [an abandoned patch](https://github.com/openjdk/jfx/pull/127) submitted by @yososs
>> 
>> There are currently 2 manual tests for this fix.
>
> Just wondering, isn't it also possible to write some unit tests for the MultipleSelectionModel(Base) ?

@Maran23 I don't know what would be an apt unit test as the PR changes implementation detail. If you have suggestions, please let me know.

There are 276 unit tests in `test.javafx.scene.control.MultipleSelectionModelImplTest` and all of them still pass with the changes made to this PR.

-------------

PR: https://git.openjdk.java.net/jfx/pull/673


More information about the openjfx-dev mailing list