RFR: 8274433: All Cells: misbehavior of startEdit

[Jeanette Winzenburg]

On Fri, 1 Oct 2021 13:11:21 GMT, Marius Hanl <mhanl at openjdk.org> wrote:

>> The misbehavior happens if (super) startEdit didn't succeed (== !cell.isEditing):
>> 
>> - must not fire editStart event
>> - must not update control's editing location
>> 
>> fix is to back out of startEdit if super.startEdit doesn't switch the cell into editing mode
>> 
>> Added tests that failed/passed before/after the fix. Note that for Tree-, Table-, TreeTableCell one of the added tests would be a false green due to those cells not updating the editing location on its control [JDK-8187474](https://bugs.openjdk.java.net/browse/JDK-8187474), so it's ignore until that's fixed.
>
> modules/javafx.controls/src/test/java/test/javafx/scene/control/TreeCellTest.java line 870:
> 
>> 868:         cell.startEdit();
>> 869:         assertFalse("sanity: off-range cell must not be editing", cell.isEditing());
>> 870:         assertEquals("editing location", null, tree.getEditingItem());
> 
> Minor: This can be replaced with `assertNull`, which would also be a bit more readable :)

haha .. left-over from c&p (of ListCellTest ;)

-------------

PR: https://git.openjdk.java.net/jfx/pull/636