RFR: 8273485: Deadlock when also using Swing and exiting Fullscreen on Mac [v6]

[Kevin Rushforth]

On Tue, 28 Sep 2021 12:07:36 GMT, Florian Kirmaier <fkirmaier at openjdk.org> wrote:

>> When using Swing it's possible to generate a Deadlock.
>>  It's related to the nested eventloop started in enterFullScreenExitingLoop - and the RenderLock aquired when using setView in Scene.
>>  Sample Programm and Threaddump are added to the ticket.
>> 
>> Removing the nested loop fixes the Problem. 
>> I hope this doesn't have any side effect - so far i don't know of any.
>
> Florian Kirmaier has updated the pull request incrementally with one additional commit since the last revision:
> 
>   JDK-8273485
>   removed the toggle fullscreen before closing - to avoid the beep and improve the user experience

I spoke too soon. I was running a few other manual tests, and your latest fix completely breaks the normal exit from full screen mode. To reproduce this:

1. Run `java hello.HelloFullscreenToggle`
2. Press the `Toggle Fullscreen` button to enter full-screen mode
3. Try to exit full screen mode, either by pressing the `ESC` key or by pressing the `Toggle Fullscreen` button again.
BUG: you can't exit full-screen mode.

-------------

PR: https://git.openjdk.java.net/jfx/pull/622