RFR: 8187474: Tree-/TableCell, TreeCell: editingCell/Item not updated in cell.startEdit [v2]

Marius Hanl mhanl at openjdk.java.net
Thu Oct 21 18:54:13 UTC 2021


On Fri, 15 Oct 2021 10:21:12 GMT, Jeanette Winzenburg <fastegal at openjdk.org> wrote:

>> cell startEdit is supposed to update the editing location on its associated control - was done in ListCell, not in Tree-/TableCell nor TreeCell.
>> 
>> Fix was to add control.edit(..). Note that ListCell was also touched to use the exact same method call pattern as the fixed cell types.
>> 
>> Added/unignored cell tests that are failing/passing before/after the fix.
>
> Jeanette Winzenburg has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fixed formatting as suggested in review
>   
>   and removed unused (by this fix) import in same file

modules/javafx.controls/src/test/java/test/javafx/scene/control/TableCellTest.java line 548:

> 546:         int editingRow = 1;
> 547:         cell.updateIndex(editingRow);
> 548:         TablePosition<?,?> editingCell = new TablePosition<>(table, editingRow, editingColumn);

Just saw you added the space for the `<?,?>` in line 559 (which I didn't saw ��) but not here :)

-------------

PR: https://git.openjdk.java.net/jfx/pull/638


More information about the openjfx-dev mailing list