RFR: 8255015: Inconsistent illumination of 3D shape by PointLight [v5]

Andreas Heger duke at openjdk.java.net
Fri Oct 22 15:01:38 UTC 2021


> The inconsistent illumination happens on Macs with retina displays only if the 3D shape is placed in a SubScene. The light sources are located with wrong coordinates in sub scenes and this causes a different illumination. The wrong coordinates for the light sources come from the fact that the retina pixel scale factors are not used in a SubScene.
> 
> With this pull request, the retina pixel scale factors will be also used in SubScenes and this should resolve the bug [https://bugs.openjdk.java.net/browse/JDK-8255015](url)

Andreas Heger has updated the pull request incrementally with one additional commit since the last revision:

  JUnit Test class for verifying JDK-8255015 added.

-------------

Changes:
  - all: https://git.openjdk.java.net/jfx/pull/531/files
  - new: https://git.openjdk.java.net/jfx/pull/531/files/c7e58901..a3677124

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jfx&pr=531&range=04
 - incr: https://webrevs.openjdk.java.net/?repo=jfx&pr=531&range=03-04

  Stats: 180 lines in 1 file changed: 180 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jfx/pull/531.diff
  Fetch: git fetch https://git.openjdk.java.net/jfx pull/531/head:pull/531

PR: https://git.openjdk.java.net/jfx/pull/531


More information about the openjfx-dev mailing list