RFR: 8255015: Inconsistent illumination of 3D shape by PointLight [v8]

Andreas Heger duke at openjdk.java.net
Fri Oct 22 16:15:34 UTC 2021


> The inconsistent illumination happens on Macs with retina displays only if the 3D shape is placed in a SubScene. The light sources are located with wrong coordinates in sub scenes and this causes a different illumination. The wrong coordinates for the light sources come from the fact that the retina pixel scale factors are not used in a SubScene.
> 
> With this pull request, the retina pixel scale factors will be also used in SubScenes and this should resolve the bug [https://bugs.openjdk.java.net/browse/JDK-8255015](url)

Andreas Heger has updated the pull request incrementally with one additional commit since the last revision:

  8255015: Tabs removed from PointLightIllumination.java

-------------

Changes:
  - all: https://git.openjdk.java.net/jfx/pull/531/files
  - new: https://git.openjdk.java.net/jfx/pull/531/files/4168f5f3..b0b6c13b

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jfx&pr=531&range=07
 - incr: https://webrevs.openjdk.java.net/?repo=jfx&pr=531&range=06-07

  Stats: 7 lines in 1 file changed: 0 ins; 0 del; 7 mod
  Patch: https://git.openjdk.java.net/jfx/pull/531.diff
  Fetch: git fetch https://git.openjdk.java.net/jfx pull/531/head:pull/531

PR: https://git.openjdk.java.net/jfx/pull/531


More information about the openjfx-dev mailing list