RFR: 8255015: Inconsistent illumination of 3D shape by PointLight [v11]
Andreas Heger
duke at openjdk.java.net
Sun Oct 24 17:23:40 UTC 2021
> The inconsistent illumination happens on Macs with retina displays only if the 3D shape is placed in a SubScene. The light sources are located with wrong coordinates in sub scenes and this causes a different illumination. The wrong coordinates for the light sources come from the fact that the retina pixel scale factors are not used in a SubScene.
>
> With this pull request, the retina pixel scale factors will be also used in SubScenes and this should resolve the bug [https://bugs.openjdk.java.net/browse/JDK-8255015](url)
Andreas Heger has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 10 additional commits since the last revision:
- Merge branch 'openjdk:master' into fix-8255015
- 8255015: Comments corrected
- 8255015: Comment about copying pixel scale factors corrected
- 8255015: Tabs removed from PointLightIllumination.java
- Merge branch 'openjdk:master' into fix-8255015
- 8255015: JUnit Test class added.
- Merge branch 'openjdk:master' into fix-8255015
- Merge branch 'openjdk:master' into fix-8255015
- Merge branch 'openjdk:master' into fix-8255015
- 8255015: Copy pixel scale factors from graphics object to subscene graphics so that the position of lights will be scaled correctly on retina displays
-------------
Changes:
- all: https://git.openjdk.java.net/jfx/pull/531/files
- new: https://git.openjdk.java.net/jfx/pull/531/files/cc995300..656cb7d8
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=jfx&pr=531&range=10
- incr: https://webrevs.openjdk.java.net/?repo=jfx&pr=531&range=09-10
Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod
Patch: https://git.openjdk.java.net/jfx/pull/531.diff
Fetch: git fetch https://git.openjdk.java.net/jfx pull/531/head:pull/531
PR: https://git.openjdk.java.net/jfx/pull/531
More information about the openjfx-dev
mailing list