RFR: 8187474: Tree-/TableCell, TreeCell: editingCell/Item not updated in cell.startEdit [v3]

Marius Hanl mhanl at openjdk.java.net
Mon Oct 25 20:58:09 UTC 2021


On Fri, 22 Oct 2021 10:36:24 GMT, Jeanette Winzenburg <fastegal at openjdk.org> wrote:

>> cell startEdit is supposed to update the editing location on its associated control - was done in ListCell, not in Tree-/TableCell nor TreeCell.
>> 
>> Fix was to add control.edit(..). Note that ListCell was also touched to use the exact same method call pattern as the fixed cell types.
>> 
>> Added/unignored cell tests that are failing/passing before/after the fix.
>
> Jeanette Winzenburg has updated the pull request incrementally with one additional commit since the last revision:
> 
>   next try with fixing the formatting

Looks good. ��

-------------

Marked as reviewed by mhanl (Author).

PR: https://git.openjdk.java.net/jfx/pull/638


More information about the openjfx-dev mailing list