RFR: 8255015: Inconsistent illumination of 3D shape by PointLight [v12]

[Kevin Rushforth]

On Tue, 26 Oct 2021 19:48:41 GMT, Andreas Heger <duke at openjdk.java.net> wrote:

>> The inconsistent illumination happens on Macs with retina displays only if the 3D shape is placed in a SubScene. The light sources are located with wrong coordinates in sub scenes and this causes a different illumination. The wrong coordinates for the light sources come from the fact that the retina pixel scale factors are not used in a SubScene.
>> 
>> With this pull request, the retina pixel scale factors will be also used in SubScenes and this should resolve the bug [https://bugs.openjdk.java.net/browse/JDK-8255015](url)
>
> Andreas Heger has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8255015: testScene variable must be volatile and new line at the end of the file added

Looks good. I ran the test on all three platforms. On macOS I ran the test on both a retina and non-retina screen.

-------------

Marked as reviewed by kcr (Lead).

PR: https://git.openjdk.java.net/jfx/pull/531