RFR: 8274061: Tree-/TableRowSkin: misbehavior on switching skin [v2]

[Jeanette Winzenburg]

On Tue, 26 Oct 2021 12:07:23 GMT, Ajit Ghaisas <aghaisas at openjdk.org> wrote:

>> Jeanette Winzenburg has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   re-added forgotten code comments
>
> modules/javafx.controls/src/main/java/javafx/scene/control/skin/TableRowSkin.java line 134:
> 
>> 132:                 // that when it changes, we can appropriately add / remove cells that may or may not
>> 133:                 // be required (because we remove all cells that are not visible).
>> 134:                 registerChangeListener(getVirtualFlow().widthProperty(), e -> tableView.requestLayout());
> 
> If this listener is removed, then is there a chance of reintroducing [JDK-8144500](https://bugs.openjdk.java.net/browse/JDK-8144500)?
> Unfortunately, there is no test added for that bug.. so it is difficult to catch regression, if any.

hmm .. the listener is not removed, its registration is moved to updateTableViewSkin. There are tests covering that it really is still registered :)

Forgot to move the old code comment, though. Re-added.

> modules/javafx.controls/src/main/java/javafx/scene/control/skin/TreeTableRowSkin.java line 154:
> 
>> 152:                 // that when it changes, we can appropriately add / remove cells that may or may not
>> 153:                 // be required (because we remove all cells that are not visible).
>> 154:                 registerChangeListener(getVirtualFlow().widthProperty(), e -> treeTableView.requestLayout());
> 
> Same comment as in TableRowSkin regarding this listener.

same comment as to TableRowSkin :)

-------------

PR: https://git.openjdk.java.net/jfx/pull/632