RFR: 8255015: Inconsistent illumination of 3D shape by PointLight [v12]

Andreas Heger duke at openjdk.java.net
Thu Oct 28 13:50:44 UTC 2021


On Wed, 27 Oct 2021 09:36:20 GMT, Ambarish Rapte <arapte at openjdk.org> wrote:

>> Andreas Heger has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8255015: testScene variable must be volatile and new line at the end of the file added
>
> tests/system/src/test/java/test/robot/test3d/PointLightIlluminationTest.java line 148:
> 
>> 146:      * Creates a new scene with a subscene which contains a perspective camera and a sphere
>> 147:      * Although this test class checks the pointlight illumination, there is no explicit pointlight
>> 148:      * in the scene. For the test, it is sufficient to use the default pointlight which is created
> 
> minor: Please include this small correction along with the copyright year change. 
> pointlight -> point light

Thanks for the review! I corrected the copyright year and the point light spelling.

-------------

PR: https://git.openjdk.java.net/jfx/pull/531


More information about the openjfx-dev mailing list