RFR: 8271091: Missing API docs in UI controls classes [v5]

[Kevin Rushforth]

On Thu, 28 Oct 2021 14:27:52 GMT, Ajit Ghaisas <aghaisas at openjdk.org> wrote:

>> This PR fixes javadoc warnings in javafx.controls and javafx.web modules.
>> Note : 
>> - The javadoc needs to be generated with the JDK 18 EA build.
>> - 2 javadoc warnings in javafx.controls TabPane class will be fixed under - [JDK-8271085](https://bugs.openjdk.java.net/browse/JDK-8271085)
>> - There are still 20 javadoc warnings remaining in javafx.controls module and 3 warnings remaining in javafx.web module. The root cause is different and they will be addressed under [JDK-8270996](https://bugs.openjdk.java.net/browse/JDK-8270996)
>
> Ajit Ghaisas has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fix review comments

The doc changes look good. Please revert the access modifier change.

modules/javafx.controls/src/main/java/javafx/scene/control/PopupControl.java line 1132:

> 1130:          * Constructor for subclasses to call.
> 1131:          */
> 1132:         protected CSSBridge() {

Please revert this change. Since the class is protected, it's a compatible change, but any change to a method's signature, return type, or modifiers needs a CSR.

-------------

Changes requested by kcr (Lead).

PR: https://git.openjdk.java.net/jfx/pull/646