RFR: 8269907 memory leak - Dirty Nodes / Parent removed [v2]
Florian Kirmaier
fkirmaier at openjdk.java.net
Fri Oct 29 11:10:17 UTC 2021
On Thu, 14 Oct 2021 14:29:55 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:
>> Florian Kirmaier has updated the pull request incrementally with one additional commit since the last revision:
>>
>> JDK-8269907
>> The bug is now fixed in a new way. Toolkit now supports registering CleanupListeners, which can clean up the dirty nodes, avoiding memoryleaks.
>
> I don't have a good suggestion at the moment.
>
> Converting this to Draft, since it isn't (yet) ready for review.
@kevinrushforth
Can we rediscuss whether this version of the fix is ok?
I think the fix is technically fine.
Adding a "runLater" like api to the PulseListener should also be fine, and might be useful for other problems too.
The fix is also already used in production - for the latest [JPro](https://jpro.one/) version and for desktop applications. Therefore I'm very confident, that this fix doesn't cause any problems.
This fix is also very important for large desktop applications. In context with Popups, the bug can cause unpredictable memory leaks.
-------------
PR: https://git.openjdk.java.net/jfx/pull/584
More information about the openjfx-dev
mailing list