RFR: 8274854: Mnemonics for menu containing numeric text not working [v3]

John Hendrikx jhendrikx at openjdk.java.net
Fri Oct 29 22:22:11 UTC 2021


On Fri, 29 Oct 2021 20:54:04 GMT, Michael Strauß <mstrauss at openjdk.org> wrote:

>> modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/behavior/TextBinding.java line 188:
>> 
>>> 186:         int i = 0;
>>> 187: 
>>> 188:         // Parse the input string and stop after the first mnemonic.
>> 
>> This seems to do much more than just fixing numeric mnemonics.  Now it stops after the first mnemonic, whereas it picked the last mnemonic before this change (which seems to be a regression from what happened in jfx16).
>> 
>> I think the regression should be fixed first, then additional features can be added?
>
> This PR does not add any additional feature. It restores the behavior of jfx16, where any character is acceptable as a mnemonic, and the first mnemonic is selected.

Okay, the wording of the JBS ticket suggested something else, but I see it is just a regression fix.

-------------

PR: https://git.openjdk.java.net/jfx/pull/647


More information about the openjfx-dev mailing list