RFR: 8273071: SeparatorSkin: must remove child on dispose

Ambarish Rapte arapte at openjdk.java.net
Fri Sep 3 09:59:38 UTC 2021


On Thu, 2 Sep 2021 12:45:02 GMT, Jeanette Winzenburg <fastegal at openjdk.org> wrote:

> minor skin cleanup issue: SeparatorSkin didn't remove the line it added to the control's children
> 
> fix is to override dispose and include the removal
> for testing: removed the exclusion of SeparatorSkin from memoryLeakTest - doing so lets it fail/pass before/after this fix

looks good to me.

-------------

Marked as reviewed by arapte (Reviewer).

PR: https://git.openjdk.java.net/jfx/pull/616


More information about the openjfx-dev mailing list