Integrated: 8269871: CellEditEvent: must not throw NPE in accessors

Jeanette Winzenburg fastegal at openjdk.java.net
Mon Sep 6 08:53:51 UTC 2021


On Thu, 26 Aug 2021 14:09:58 GMT, Jeanette Winzenburg <fastegal at openjdk.org> wrote:

> The issue is unguarded access to tablePosition though it might be null (since [JDK-8120610](https://bugs.openjdk.java.net/browse/JDK-8120610)
> 
> The fix is to check against null in each accessor. Also required to fix the default onEditCommit handlers in Tree/TableColumn to really cope with null TablePostion on the event.
> 
> Added tests that failed/pass before/after the fix.
> 
> Note that there was an old test (in Tree/TableColumnTest each), that failed after the fix because it expected the NPE. Fixed by removing the expected parameter.

This pull request has now been integrated.

Changeset: 78ae4a81
Author:    Jeanette Winzenburg <fastegal at openjdk.org>
URL:       https://git.openjdk.java.net/jfx/commit/78ae4a815b728f5a0dca8fa6de8ca68a27a1d189
Stats:     411 lines in 6 files changed: 391 ins; 5 del; 15 mod

8269871: CellEditEvent: must not throw NPE in accessors

Reviewed-by: aghaisas

-------------

PR: https://git.openjdk.java.net/jfx/pull/611


More information about the openjfx-dev mailing list