RFR: 8090547: Allow for transparent backgrounds in WebView [v6]

Michael Paus mpaus at openjdk.java.net
Mon Sep 6 10:07:48 UTC 2021


On Fri, 27 Aug 2021 17:01:00 GMT, Jose Pereda <jpereda at openjdk.org> wrote:

>> Currently, `WebPage` has already a public `setBackgroundColor()` method, but the class is not public. Therefore, public API is needed in `WebView` to allow developers access to it.
>> 
>> In line with the `fontSmoothingType` property, this PR provides public support for setting the background color of a WebPage, by adding a `pageFill` property, and a CSR is required.
>> 
>> The color for the background, that can be opaque, transparent or with any level of opacity, can be set via code or via CSS using `-fx-page-fill`.
>> 
>> Unit tests and a system test are provided.
>
> Jose Pereda has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Use color to int32 converter instead of hash

Always referring to Int32 is very vague and does not provide any information because this information is kind of obvious from the argument. It would be clearer to say RGBA (or whatever your assumption is) because that might help avoid confusion about which color component ordering you actually expect in your Int32.

-------------

PR: https://git.openjdk.java.net/jfx/pull/563


More information about the openjfx-dev mailing list