RFR: 8090547: Allow for transparent backgrounds in WebView [v5]

[Kevin Rushforth]

On Sun, 29 Aug 2021 06:36:40 GMT, Michel Jung <github.com+1864183+micheljung at openjdk.org> wrote:

>> Jose Pereda has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Color to int32 conversion and more changes based on feedback
>
> modules/javafx.web/src/main/java/com/sun/webkit/WebPage.java line 629:
> 
>> 627:         try {
>> 628:             log.fine("setBackgroundColor int32: " + backgroundColor +
>> 629:                    " for all frames");
> 
> I don't know JavaFX's PlatformLogger but this should probably be:
> 
> Suggestion:
> 
>             log.fine("setBackgroundColor int32: {} for all frames", backgroundColor);
> 
> or:
> 
> Suggestion:
> 
>             if(log.isTraceEnabled()) {
>                 log.fine("setBackgroundColor int32: {} for all frames", backgroundColor);
>             }
> 
> 
> Even though this probably isn't something that's called very often :)

Or just wrap the call in a test for `if (log.isLoggable(Level.FINE))`, which is similar to what was done earlier. In any case, this is just modifying the contents of the String and is otherwise preexisting code, so I'll leave it up to @jperedadnr as to whether he wants to change it.

-------------

PR: https://git.openjdk.java.net/jfx/pull/563