Integrated: 8089398: [ChoiceBox, ComboBox] throws NPE on setting value on null selectionModel

Marius Hanl mhanl at openjdk.java.net
Thu Sep 9 08:33:06 UTC 2021


On Wed, 30 Jun 2021 15:03:50 GMT, Marius Hanl <mhanl at openjdk.org> wrote:

> This PR fixes multiple NPEs in Choice-and ComboBox, when the selection model is null.
> 
> ChoiceBox: 
> - Null check in **valueProperty()** listener
> 
> ComboBox:
> - Null check in **editableProperty()** listener
> - Null check in **valueProperty()** listener
> - Null check in **ComboBoxListViewSkin#updateValue()**
> - Null check in **ComboBoxListViewSkin#layoutChildren()**
> - 2x Null check in **ComboBoxListViewSkin#createListView()**
> 
> ~~The tests checks, that no NPE is printed to the console.
> Some checks, that the set value is still displayed (either in the ComboBox button cell or the ChoiceBox display label)~~

This pull request has now been integrated.

Changeset: f987b181
Author:    Marius Hanl <mhanl at openjdk.org>
Committer: Jeanette Winzenburg <fastegal at openjdk.org>
URL:       https://git.openjdk.java.net/jfx/commit/f987b181aba1d3d56e745bd02fe350287ab57459
Stats:     141 lines in 5 files changed: 127 ins; 3 del; 11 mod

8089398: [ChoiceBox, ComboBox] throws NPE on setting value on null selectionModel

Reviewed-by: fastegal, aghaisas

-------------

PR: https://git.openjdk.java.net/jfx/pull/557


More information about the openjfx-dev mailing list