RFR: 8272870: Add convenience factory methods for border and background [v3]
Nir Lisker
nlisker at openjdk.java.net
Wed Sep 15 13:36:29 UTC 2021
On Wed, 15 Sep 2021 11:08:04 GMT, Ambarish Rapte <arapte at openjdk.org> wrote:
>> Nir Lisker has updated the pull request incrementally with two additional commits since the last revision:
>>
>> - Removed whitespaces
>> - Added tests and doc updates
>
> modules/javafx.graphics/src/test/java/test/javafx/scene/layout/BackgroundTest.java line 722:
>
>> 720: @Test
>> 721: public void testSingleFill() {
>> 722: var background1 = Background.fill(Color.BEIGE);
>
> I think we should have a test for null argument too.
> Similar for the test BorderTest.testSingleStroke()
Yes, I wanted to add these but forgot.
-------------
PR: https://git.openjdk.java.net/jfx/pull/610
More information about the openjfx-dev
mailing list