RFR: 8255015: Inconsistent illumination of 3D shape by PointLight [v4]
Andreas Heger
github.com+85555697+andreas-heger at openjdk.java.net
Mon Sep 20 13:46:16 UTC 2021
> The inconsistent illumination happens on Macs with retina displays only if the 3D shape is placed in a SubScene. The light sources are located with wrong coordinates in sub scenes and this causes a different illumination. The wrong coordinates for the light sources come from the fact that the retina pixel scale factors are not used in a SubScene.
>
> With this pull request, the retina pixel scale factors will be also used in SubScenes and this should resolve the bug [https://bugs.openjdk.java.net/browse/JDK-8255015](url)
Andreas Heger has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
- Merge branch 'openjdk:master' into fix-8255015
- Merge branch 'openjdk:master' into fix-8255015
- Merge branch 'openjdk:master' into fix-8255015
- 8255015: Copy pixel scale factors from graphics object to subscene graphics so that the position of lights will be scaled correctly on retina displays
-------------
Changes:
- all: https://git.openjdk.java.net/jfx/pull/531/files
- new: https://git.openjdk.java.net/jfx/pull/531/files/fdb1ddbe..c7e58901
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=jfx&pr=531&range=03
- incr: https://webrevs.openjdk.java.net/?repo=jfx&pr=531&range=02-03
Stats: 179 lines in 6 files changed: 156 ins; 18 del; 5 mod
Patch: https://git.openjdk.java.net/jfx/pull/531.diff
Fetch: git fetch https://git.openjdk.java.net/jfx pull/531/head:pull/531
PR: https://git.openjdk.java.net/jfx/pull/531
More information about the openjfx-dev
mailing list