RFR: 8090158: Wrong implementation of adjustValue in scrollBars [v2]

Ajit Ghaisas aghaisas at openjdk.java.net
Tue Sep 21 09:15:50 UTC 2021


On Tue, 21 Sep 2021 08:53:07 GMT, Hadzic Samir <shadzic at openjdk.org> wrote:

>> JBS bug: [JDK-8090158](https://bugs.openjdk.java.net/browse/JDK-8090158)
>> 
>> The javadoc of the ScrollBar#adjustValue specifically says that it will adjust the value based on the block increment value. Therefore, there is no reason to stop at the given value when reaching an end.
>
> Hadzic Samir has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix upon review

Marked as reviewed by aghaisas (Reviewer).

I prefer small targeted bug fixes. The assert order in other tests in this file can be fixed separately.

-------------

PR: https://git.openjdk.java.net/jfx/pull/582


More information about the openjfx-dev mailing list