RFR: 8255015: Inconsistent illumination of 3D shape by PointLight

Andreas Heger github.com+85555697+andreas-heger at openjdk.java.net
Wed Sep 22 14:27:56 UTC 2021


On Mon, 20 Sep 2021 14:11:50 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> @kevinrushforth 
>>> The fix looks good. I tested it both in isolation and with PR #334 and it works on both a retina and non-retina display.
>>> 
>>> If you have time to write an automated test, that would be useful, but if not then a manual test would be OK.
>> 
>> Ok, I will try to write an automated test case which draws a sphere in a SubScene and then calculates the average color of the generated image. The test will be passed if the calculated average does not differ from the excepted average color by a certain tolerance value. I'm not sure if I will manage to do this... but I will give it a try.
>
> @andreas-heger are you able to come up with an automated test for this bug?

@kevinrushforth yes, I still want to write an automated test for this bug. Sorry for the delay... I plan to do it within the next two weeks.

-------------

PR: https://git.openjdk.java.net/jfx/pull/531


More information about the openjfx-dev mailing list