RFR: Draft: 8274274: Update JavaFX test framework to JUnit 5 [v2]

[John Hendrikx]

On Fri, 24 Sep 2021 20:48:26 GMT, John Hendrikx <jhendrikx at openjdk.org> wrote:

>> gradle/verification-metadata.xml line 247:
>> 
>>> 245:             <sha256 value="e08028131375b357d1d28734e9a4fb4216da84b240641cb3ef7e7c7d628223fc" origin="Generated by Gradle"/>
>>> 246:          </artifact>
>>> 247:       </component>
>> 
>> Is `apiguardian` actually required in order to support JUnit 5? If not, this should be reverted. If so, that's another third-party dependency we would need to get approval for.
>
> It's an annotation used within JUnit code, it might be possible to block this one, I will see how to do this in Gradle syntax.
> 
> This is the whole transitive tree it pulls in:
> ![image](https://user-images.githubusercontent.com/995917/134737975-8cc2aca3-6b58-488d-b9b5-b6c4906d653f.png)

Blocked this one without ill effects, tests still run.

>> gradle/verification-metadata.xml line 345:
>> 
>>> 343:             <sha256 value="a96e671816c1ff8803bdec74c9241f025bdfb277da5d2b4ee02266405936f994" origin="Generated by Gradle"/>
>>> 344:          </artifact>
>>> 345:       </component>
>> 
>> Is `opentest4j` actually required in order to support JUnit 5? If not, this should be reverted. If so, that's another third-party dependency we would need to get approval for.
>
> Will try block

I couldn't block opentest4j.  Apparently this is a project that harmonizes the exceptions thrown by various test frameworks (not just JUnit 5) and JUnit 5 depends on it for the exceptions it uses to signal test failures and other error conditions.  It is a fairly small project (6 classes only) licensed under the Apache 2.0 license: https://github.com/ota4j-team/opentest4j

-------------

PR: https://git.openjdk.java.net/jfx/pull/633