RFR: Draft: 8274274: Update JavaFX test framework to JUnit 5 [v3]

Kevin Rushforth kcr at openjdk.java.net
Sat Sep 25 13:15:49 UTC 2021


On Fri, 24 Sep 2021 21:20:19 GMT, John Hendrikx <jhendrikx at openjdk.org> wrote:

>> I've added JUnit 5 as a test dependency and made sure that the JUnit 4 tests still work.  Also added a single JUnit 5 tests, and confirmed it works.
>> 
>> I've updated the Eclipse project file for the base module only.
>
> John Hendrikx has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Add copyright header
>  - Remove apiguardian and hamcrest dependencies as not strictly required

The gradle verification task failed (see the test results from GitHub Actiona). It looks like it still needs the hamcrest jars. Go ahead and add them back in (and remove the exclusion for them).

-------------

PR: https://git.openjdk.java.net/jfx/pull/633


More information about the openjfx-dev mailing list