RFR: 8214158: Implement HostServices.showDocument on macOS without calling AWT

Kevin Rushforth kcr at openjdk.java.net
Tue Sep 28 17:10:37 UTC 2021


On Tue, 28 Sep 2021 16:06:30 GMT, Michael Paus <mpaus at openjdk.org> wrote:

> Fixes the issue by using the "open" command as discussed before.
> See: https://bugs.openjdk.java.net/browse/JDK-8214158

This seems like a good RFE. I have a couple overall questions.

First, calling `open` was originally proposed in the since-abandoned Draft PR javafxports/openjdk-jfx#310. As I wrote there:

> One thing of note is that the AWT code, which we are currently calling, uses a native method to call LSOpenURLsWithRole rather than "exec"-ing a new process from Java. I'm not sure why (maybe the open command wasn't as robust when it was implemented? Or maybe there is some benefit to using LSOpenURLsWithRole?), but we will need to make sure that there isn't a regression in behavior as a result."

Can you comment on this?

Second, can you provide a manual test for this? I was thinking something that would go somewhere under `tests/manual` and when run, provide an option to open one of two or three different file types (e.g., a `.txt` file and a `.html` file) that are also checked in to the same dir as the test program. It could use `FIle::toURI` or similar to construct the URI string.

-------------

PR: https://git.openjdk.java.net/jfx/pull/634


More information about the openjfx-dev mailing list