RFR: 8273339: IOOBE with ListChangeListener added to the selectedItems list of a TableView [v3]

Ajit Ghaisas aghaisas at openjdk.java.net
Thu Apr 7 12:08:58 UTC 2022


On Thu, 10 Feb 2022 10:16:36 GMT, Jose Pereda <jpereda at openjdk.org> wrote:

>> This PR converts the change's `from` field from a list of tablePositions into a list of selected indices of rows.
>> 
>> It includes two tests for TableView and one for TreeTableView (the second test wasn't included due to an [issue|https://bugs.openjdk.java.net/browse/JDK-8232825] with key navigation), that pass with this PR and fail without it.
>
> Jose Pereda has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits:
> 
>  - Merge branch 'master' into 8273339-changefrom
>  - Apply change only when cell selection is enabled
>  - Convert change from list of tablePosition to list of rows

Looks good to me.

-------------

Marked as reviewed by aghaisas (Reviewer).

PR: https://git.openjdk.java.net/jfx/pull/710


More information about the openjfx-dev mailing list