RFR: 8283218: Update GStreamer to 1.20.1
Kevin Rushforth
kcr at openjdk.java.net
Tue Apr 12 23:21:13 UTC 2022
On Fri, 8 Apr 2022 06:49:59 GMT, Alexander Matveev <almatvee at openjdk.org> wrote:
> - GStreamer updated to 1.20.1 and GLib updated to 2.72.0.
> - No changes to our code, except in GstAudioSpectrum.cpp g_atomic_pointer_compare_and_exchange() was changed to g_atomic_pointer_set(). For some reason I was not able to get code compiled with g_atomic_pointer_compare_and_exchange() used from C++ code. Also, I do not see a need to use g_atomic_pointer_compare_and_exchange(), since m_pHolder always equals to old_holder.
> - Tested on all platforms with all supported media streams.
This still uses the system Glib library on Linux, right? What Linux platforms have you tried this on? It fails for me on my local Ubuntu 16.04 system.
In file included from ../../../gstreamer-lite/gstreamer/gst/gstbuffer.c:137:
../../../gstreamer-lite/gstreamer/gst/gstbuffer.c: In function 'gst_buffer_new_m
emdup':
../../../gstreamer-lite/gstreamer/gst/glib-compat-private.h:34:90: error: implicit declaration of function 'g_abort'; did you mean 'abort'? [-Werror=implicit-function-declaration]
34 | #define g_memdup2(ptr,sz) ((G_LIKELY(((guint64)(sz)) < G_MAXUINT)) ? g_memdup(ptr,sz) : (g_abort(),NULL))
| ^~~~~~~
We compile with `-Werror=implicit-function-declaration`, so this fails the build.
-------------
PR: https://git.openjdk.java.net/jfx/pull/768
More information about the openjfx-dev
mailing list