RFR: 8283218: Update GStreamer to 1.20.1 [v2]
Kevin Rushforth
kcr at openjdk.java.net
Wed Apr 13 11:23:29 UTC 2022
On Wed, 13 Apr 2022 07:48:44 GMT, Alexander Matveev <almatvee at openjdk.org> wrote:
>> - GStreamer updated to 1.20.1 and GLib updated to 2.72.0.
>> - No changes to our code, except in GstAudioSpectrum.cpp g_atomic_pointer_compare_and_exchange() was changed to g_atomic_pointer_set(). For some reason I was not able to get code compiled with g_atomic_pointer_compare_and_exchange() used from C++ code. Also, I do not see a need to use g_atomic_pointer_compare_and_exchange(), since m_pHolder always equals to old_holder.
>> - Tested on all platforms with all supported media streams.
>
> Alexander Matveev has updated the pull request incrementally with one additional commit since the last revision:
>
> 8283218: Update GStreamer to 1.20.1 [v2]
The updated version gets past the earlier error, but still fails:
../../../gstreamer-lite/gstreamer/gst/gstelementfactory.c:494:28: error: implicit declaration of function 'g_object_new_with_properties'; did you mean 'g_object_class_list_properties'? [-Werror=implicit-function-declaration]
494 | element = (GstElement *) g_object_new_with_properties (factory->type, n,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
| g_object_class_list_properties
-------------
PR: https://git.openjdk.java.net/jfx/pull/768
More information about the openjfx-dev
mailing list