RFR: 8285360: [TestBug] Cleanup a few ignored javafx.controls unit tests [v2]

Ajit Ghaisas aghaisas at openjdk.java.net
Fri Apr 22 07:30:26 UTC 2022


On Fri, 22 Apr 2022 06:27:49 GMT, Ambarish Rapte <arapte at openjdk.org> wrote:

>> Ajit Ghaisas has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   address review comments
>
> modules/javafx.controls/src/test/java/test/javafx/scene/control/CellTest.java line 387:
> 
>> 385:         cell.requestFocus();
>> 386:         Toolkit.getToolkit().firePulse();
>> 387: 
> 
> Minor: Optional:
> Adding `assertTrue(cell.isEditing());` here can be a good sanity check. But I leave it to you.
> Similar comment for the change in `DateCellTest.loseFocusWhileEditing()`

Done.

> modules/javafx.controls/src/test/java/test/javafx/scene/control/CellTest.java line 392:
> 
>> 390: 
>> 391:         assertFalse(cell.isEditing());
>> 392:     }
> 
> I would recommend to call `stage.hide()` similar to that in the `@AfterClass cleanup` methods.
> Similar comment for the change in `DateCellTest.loseFocusWhileEditing()`

I have added `stage.hide()` to these tests, also to the `PaginationTest` class.

-------------

PR: https://git.openjdk.java.net/jfx/pull/780


More information about the openjfx-dev mailing list