RFR: 8289605: Robot capture tests fail intermittently on Mac M1 [v2]
Andy Goryachev
angorya at openjdk.org
Mon Aug 1 20:11:53 UTC 2022
On Fri, 29 Jul 2022 23:01:27 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:
> The fix works on my M1 system for the two failing tests. So my only feedback is the suggestion to move the `before` method from `RegionBackgroundImageUITest` to `VisualTestBase`.
VisualTestBase is a base class to the whole gallery of tests, some of which have more than one stage (IconifyTest). I've limited the changes to RegionBackgroundImageUITest because I did not want to expand the scope unnecessarily.
We could add it to RegionUITestBase instead (RegionBackgroundImageUITest extends RegionUITestBase extends VisualTestBase), but I got an impression that it is better for a single PR to limit the scope of the change.
Affected tests (extend RegionBackgroundImageUITest):
RegionBackgroundFillUITest
RegionBackgroundImageUITest
RegionBorderImageUITest
RegionBorderStrokeUITest (empty)
RegionShapeUITest (empty)
-------------
PR: https://git.openjdk.org/jfx/pull/854
More information about the openjfx-dev
mailing list