RFR: 8217853: Cleanup in the D3D native pipeline [v2]

[Ambarish Rapte]

On Tue, 2 Aug 2022 10:30:55 GMT, Nir Lisker <nlisker at openjdk.org> wrote:

>> I see 4 tests in `PointLightIlluminationTest` fail due to this change, on MacOS and Windows.
>> Tests: 
>> sphereLowerRightPixelColorShouldBeDarkRed
>> sphereUpperRightPixelColorShouldBeDarkRed
>> sphereUpperLeftPixelColorShouldBeDarkRed
>> sphereLowerLeftPixelColorShouldBeDarkRed
>> 
>> Error:
>> expected:rgba(139,0,0,255) but was:rgba(180,0,0,255)
>> 
>> The tests pass if isAttenuated is 1.
>
> I'll have a look. What command did you run this test with?
> 
> Can you also test the point light attenuation under `tests\system\src\test\java\test\javafx\scene\lighting3D\PointLightAttenuationTest.java`? (I think there's a bit of a mess in the tests folders.)

Command to run the system test:
`gradle -PFULL_TEST=true -PUSE_ROBOT=true systemTests:test --tests test.robot.test3d.PointLightIlluminationTest`

I ran all the tests, only above test failed:
Command to run all the system tests: `gradle -PFULL_TEST=true -PUSE_ROBOT=true systemTests:test`

-------------

PR: https://git.openjdk.org/jfx/pull/789