JavaFX 19 is in Rampdown Phase Two (RDP2)

[Kevin Rushforth]

To: OpenJFX Developers

As a reminder, JavaFX 19 is now in Rampdown Phase Two (RDP2). [1]

P1-P2 bugs, and test or doc bugs of any priority, can be fixed during 
RDP2. Explicit approval is needed for bug fixes (except for doc and test 
fixes), and all enhancements to go in to the jfx19 branch [2]. The bar 
for approving bug fixes is appropriately high at this point. We do not 
anticipate approving any more enhancements.

We will use the same rules for RDP2 that the JDK uses [3], with two 
modifications:

1. Approval is needed from one of the OpenJFX project leads (not the 
OpenJDK project lead)

2. Since we are not part of the JDK, we need to use labels that do not 
collide with the JDK 19 release. As an obvious choice, derived from the 
JBS fix version, we will use "openjfx19-fix-request", 
"openjfx19-fix-yes", "openjfx19-fix-no" and "openjfx19-fix-nmi", 
"openjfx19-enhancement-request", "openjfx19-enhancement-yes", 
"openjfx19-enhancement-no" and "openjfx19-enhancement-nmi" as 
corresponding labels.

Note that if a fix is approved to integrate into jfx19 (with the 
appropriate approval label added by a lead), then the PR should be 
targeted to the jfx19 branch. There is no need to also create a separate 
PR to integrate it into master -- we will continue to periodically sync 
jfx19 --> master for the duration of the openjfx19 release.

Now that we are in RDP2, the goal is to stabilize what is there, fixing 
bugs that are new in openjfx19. We need to be extremely careful about 
including anything that introduces risk.

IMPORTANT: Reviewers and Committers now have an extra responsibility to 
double-check the target branch of each PR that they review, integrate, 
or sponsor. By default a PR will be targeted to `master` which is the 
main development line (OpenJFX 20 as of today). This is usually what we 
want. A PR should be targeted to `jfx19` if, and only if, it is intended 
for OpenJFX 19 and meets the criteria for the current rampdown phase 
(we're in RDP2 as of today). Reviewers are advised to be extra cautious 
in approving potentially risky fixes targeted to `jfx19`. If there is a 
concern, then a reviewer can as part of the review indicate that the PR 
should be retargeted to `master` for 20. Reviewers also need to be extra 
careful when reviewing PRs targeted to jfx19 that it doesn't mistakenly 
contain any commits from the master branch. You'll be able to tell 
because the diffs will contain changes that are not part of the fix 
being reviewed. Such a PR will either need to be closed and redone, or 
it will need to be rebased and force-pushed.

Let me know if there are any questions.

-- Kevin

[1] https://mail.openjdk.org/pipermail/openjfx-dev/2022-May/034217.html
[2] https://github.com/openjdk/jfx/tree/jfx19
[3] http://openjdk.java.net/jeps/3