RFR: 8181084: JavaFX show big icons in system menu on macOS with Retina display [v5]

Kevin Rushforth kcr at openjdk.org
Thu Aug 4 22:14:30 UTC 2022


On Thu, 4 Aug 2022 08:22:29 GMT, Paul <duke at openjdk.org> wrote:

> Thinking about it, is there merit in changing the scalex and scaley checks to be != 0, as The main reason for checking at all is to prevent a division by zero. Although unlikely, could fractional values < 1 reach this code?

I doubt that a scale `< 1` is possible on Mac, although we don't preclude it in other places in the code. Negative scales would be a problem, so a `> 0` check seems fine.

-------------

PR: https://git.openjdk.org/jfx/pull/743


More information about the openjfx-dev mailing list