RFR: 8290473: update Eclipse .classpath in apps, buildSrc [v2]
Kevin Rushforth
kcr at openjdk.org
Sat Aug 6 13:27:13 UTC 2022
On Sat, 6 Aug 2022 02:28:27 GMT, Nir Lisker <nlisker at openjdk.org> wrote:
>> As with any multi-stage project, we need to run 'gradle sdk' (or perhaps 'gradle sdk apps' for good measure) to build these directories. Then, in Eclipse, clean all projects. These steps produce a working configuration.
>>
>> I do not see hlsl folders being build on Mac. Are these being built on windows/linux?
>> If these are platform-specific, then we should add them to the gradle build. Maybe an additional target that creates the empty directories, and upon which sdk depends on.
>
> As @kleopatra noted below, you need to add the hlsl folders that are built on Windows. Add them as an optional source to avoid errors on other OS's:
>
> <classpathentry kind="src" path="build/hlsl/Prism">
> <attributes>
> <attribute name="ignore_optional_problems" value="true"/>
> </attributes>
> </classpathentry>
>
> And the same for
> ```<classpathentry kind="src" path="build/gensrc/jsl-prism"/>```
> ```<classpathentry kind="src" path="build/hlsl/Decora">```
> ```<classpathentry kind="src" path="build/gensrc/jsl-decora"/>```
>
> This will allow to run dependent projects on Windows and won't cause build issues on other OS's as Eclipse ignores errors on these. There is no need to create empty folders. I tested both on Windows and Linux.
I agree that an optional dependency for a platform-specific generated source directory is a much better solution than creating an empty dir.
-------------
PR: https://git.openjdk.org/jfx/pull/858
More information about the openjfx-dev
mailing list