RFR: 8290473: update Eclipse .classpath in apps, buildSrc [v2]

Nir Lisker nlisker at openjdk.org
Sat Aug 6 13:37:13 UTC 2022


On Sat, 6 Aug 2022 13:22:17 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> As @kleopatra noted below, you need to add the hlsl folders that are built on Windows. Add them as an optional source to avoid errors on other OS's:
>> 
>> <classpathentry kind="src" path="build/hlsl/Prism">
>> 	<attributes>
>> 		<attribute name="ignore_optional_problems" value="true"/>
>> 	</attributes>
>> </classpathentry>
>> 
>> And the same for
>> ```<classpathentry kind="src" path="build/gensrc/jsl-prism"/>```
>> ```<classpathentry kind="src" path="build/hlsl/Decora">```
>> ```<classpathentry kind="src" path="build/gensrc/jsl-decora"/>```
>> 
>> This will allow to run dependent projects on Windows and won't cause build issues on other OS's as Eclipse ignores errors on these. There is no need to create empty folders. I tested both on Windows and Linux.
>
> I agree that an optional dependency for a platform-specific generated source directory is a much better solution than creating an empty dir.

I don't know what the platform-specific ones are for Mac. I can check on Linux if there's a problem running dependent projects with/without the sources and I think that it will cover Mac too.

-------------

PR: https://git.openjdk.org/jfx/pull/858


More information about the openjfx-dev mailing list