RFR: 8235491: Tree/TableView: implementation of isSelected(int) violates contract [v6]

[Andy Goryachev]

On Sat, 6 Aug 2022 14:24:59 GMT, Jeanette Winzenburg <fastegal at openjdk.org> wrote:

>> Andy Goryachev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 11 additional commits since the last revision:
>> 
>>  - 8235491: whitespace
>>  - 8235491: additional tests
>>  - Merge remote-tracking branch 'origin/master' into 8235491.isselected
>>  - 8235491: javadoc
>>  - 8235491: tree table view
>>  - Merge remote-tracking branch 'origin/master' into 8235491.isselected
>>  - 8235491: review comments
>>  - 8235491: whitespace
>>  - 8235491: javadoc
>>  - 8235491: 2022
>>  - ... and 1 more: https://git.openjdk.org/jfx/compare/40ef8a73...ad3c70b9
>
> modules/javafx.controls/src/test/java/test/javafx/scene/control/TableViewMouseInputTest.java line 558:
> 
>> 556:         sm.setSelectionMode(SelectionMode.MULTIPLE);
>> 557:         sm.clearSelection();
>> 558: 
> 
> wondering: why did you add the clearSelection?

it was an attempt to ensure a clear initial state, but you are right - it is unnecessary.

-------------

PR: https://git.openjdk.org/jfx/pull/839