RFR: 8290844: Add Skin.install() method

John Hendrikx jhendrikx at openjdk.org
Mon Aug 8 20:37:50 UTC 2022


On Fri, 22 Jul 2022 19:22:48 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

> - added Skin.install()
> - javadoc changes for Skinnable.setSkin(Skin)
> 
> no code changes for Skinnable.setSkin(Skin) yet.

modules/javafx.controls/src/main/java/javafx/scene/control/Control.java line 244:

> 242:             // check whether the skin is for right control
> 243:             if (skin != null) {
> 244:                 if(skin.getSkinnable() != Control.this) {

minor: Perhaps write this as one `if` (saves an indent level) or at least make the space after `if` consistent between the two.

-------------

PR: https://git.openjdk.org/jfx/pull/845


More information about the openjfx-dev mailing list