RFR: 8235491: Tree/TableView: implementation of isSelected(int) violates contract [v9]

Andy Goryachev angorya at openjdk.org
Tue Aug 9 21:43:58 UTC 2022


> 1. reword SelectionModel.isSelected(int) javadoc, removing incorrect statement "Is functionally equivalent to calling <code>getSelectedIndices().contains(index)</code>." 
> 2. reimplement TableView.TableViewSelectionModel.isSelected(int) method to return true when at least one cell in *any* column is selected on the given row (was: *all* columns)
> 3. change selectRowWhenInSingleCellSelectionMode() and selectRowWhenInSingleCellSelectionMode2() in TableViewSelectionModelImplTest to reflect new reality.
> 
> NOTE: proposed change alters semantics of isSelected(int) method (in the right direction, in my opinion).

Andy Goryachev has updated the pull request incrementally with two additional commits since the last revision:

 - 8235491: updated test
 - 8235491: removed unnecessary method

-------------

Changes:
  - all: https://git.openjdk.org/jfx/pull/839/files
  - new: https://git.openjdk.org/jfx/pull/839/files/9de5858b..76466935

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jfx&pr=839&range=08
 - incr: https://webrevs.openjdk.org/?repo=jfx&pr=839&range=07-08

  Stats: 23 lines in 4 files changed: 0 ins; 20 del; 3 mod
  Patch: https://git.openjdk.org/jfx/pull/839.diff
  Fetch: git fetch https://git.openjdk.org/jfx pull/839/head:pull/839

PR: https://git.openjdk.org/jfx/pull/839


More information about the openjfx-dev mailing list